Extend palette contract: Palette capabilities#5032
Closed
zeehio wants to merge 3 commits into
Closed
Conversation
This was referenced Nov 6, 2022
We can extend palettes with attributes to improve the mapping efficiency. With this commit a palette may define an attribute `may_return_na` to `FALSE`. If it does, `ScaleContinuous` will assume the palette may not return missing values, and it will skip checking for those and replacing them.
d9d6dea to
d9e577d
Compare
Collaborator
|
Closing this PR in favour of #6344. Thank you for exploring this problem, but I feel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this pull request is to improve the performance of checking for missing values when mapping values to colours using a palette.
Some palettes may be able to guarantee that they never return missing values as colours. For those palettes it does not make sense that we check if there are missing values in their output.
In this pull request, I use (although I don't depend on it):
Basically, that pull request extends the palette contract by adding attributes to it. One of those attributes is
may_return_NAwhich, if set toFALSE, then ggplot2 can assume the output of the palette has no missing values and skip the corresponding check.The relevant part of this pull request is:
Related to: